Re: [PATCH iwl-net] idpf: add missing cpu_to_le32 in idpf_tx_splitq_build_flow_desc
Willem de Bruijn <[email protected]> Mon, 03 Aug 2026 17:11:42 -0400
| Newsgroups | org.kernel.vger.netdev |
|---|---|
| Message-ID | <[email protected]> |
Tony Nguyen wrote: > > > On 8/2/2026 7:31 AM, Willem de Bruijn wrote: > > Willem de Bruijn wrote: > >> From: Willem de Bruijn <[email protected]> > >> > >> idpf_tx_splitq_build_flow_desc performs a 32-bit store to &cmd_dtype > >> to set the 8-bit cmd_dtype and zero the adjacent 3-byte timestamp > >> field in a single operation. > >> > >> Descriptors are in little endian. Add missing cpu_to_le32 and cast to > >> __le32 to ensure the fields are written correctly also on big endian > >> platforms. > >> > >> Signed-off-by: Willem de Bruijn <[email protected]> > > > > Fixes: 1a49cf814fe1 ("idpf: add Tx timestamp flows") > > > > Forgot the tag. Apologies. > > I see it's for 'iwl-net' but IWL isn't on the send list. Seems > straightforward enough that if netdev wants to take it directly, it's ok > with me. If yes, > > Reviewed-by: Tony Nguyen <[email protected]> > > Otherwise, could you add the Fixes and include IWL > ([email protected]) on the send? > > Thanks, > Tony > Oops. Resent with both and your Reviewed-by. Thanks Tony. https://lore.kernel.org/netdev/[email protected]/