Re: [PATCH 2/2] qlcnic: move notifier error cleanup under CONFIG_INET

Jakub Kicinski <[email protected]> Mon, 3 Aug 2026 16:22:16 -0700
Newsgroups org.kernel.vger.netdev,org.kernel.vger.linux-kernel
Message-ID <[email protected]>
On Tue, 28 Jul 2026 11:20:46 +0800 Can Peng wrote:
> qlcnic_init_module() registers the netdevice and inetaddr notifiers only
> when CONFIG_INET is enabled, but the pci_register_driver() error handling
> block is outside that guard.
> 
> Move the error check under CONFIG_INET together with the cleanup it
> protects. This avoids an empty if statement when CONFIG_INET is disabled
> and keeps the cleanup code structured like the guarded registration path.

Waste of time. Like a lot of patches from @kylinos.cn patches, sadly.