Re: [RFC net-next 0/2] hsr: Use only one MAC address per node
Hangbin Liu <[email protected]>
| Newsgroups | org.kernel.vger.netdev |
|---|---|
| Message-ID | <anKiHmSnUjBOw1f2@fedora> |
Hi Felix, On 14.07.2026 12:52, Felix Maurer wrote: >To prevent misconfiguration and simplify the hsr code, this patchset >removes the notion of two different MAC addresses for one node in the >network entirely. The first patch sets equal addresses on both ports so >that we are not running in invalid configurations. I also updates the >selftest to not use/expect different addresses on the two ports. The >second patch removes MAC address B from the node table and thereby >eliminates a lot of code, including the node merging. > >I am posting as an RFC for now mostly for two reasons: First, I want to >make sure it's generally accepted to have only a single MAC address per >node and give everyone the chance to speak up against this. > >Second, I adapted the PRP address handling to HSR as well, i.e., to copy >the address from port A to port B and master, mostly because it is low >effort. I am not sure though if this is the best approach now that we +1 for this behavior. Bonding also use this one as default behavior. Thanks Hangbin