Re: [PATCH v2 1/2] w5100: restore GPIO-based link detection

On Tue, Aug 4, 2026, at 22:58, Jakub Kicinski wrote:
> On Tue, 04 Aug 2026 19:40:56 +0200 Arthur Crépin Leblond wrote:
>> Commit dacf281771a9 ("w5100: remove unused gpio link detection")
>
> Sounds like a fix, so the two patches should probably travel separately,
> the fix with a Fixes tag and more explanation (what you have in the
> cover letter and more) in the message.
>
> And the conversion should travel via net-next.

It's not really a fix for my patch though: the original code never
worked on mainline kernels because the w5100_spi_probe() function
always passed -EINVAL as the gpio number since it was first added in
630cf09751fe ("net: w5100: support SPI interface mode"). Arthur
correctly adds support for the link gpio line using DT probing.

I would suggest rewording the patch description to clarify this
by describing what the added code does first before mentioning
the removal of the old version.

      Arnd