RE: [Intel-wired-lan] [PATCH iwl-net v2] idpf: add missing cpu_to_le32 in idpf_tx_splitq_build_flow_desc

> -----Original Message-----
> From: Intel-wired-lan <[email protected]> On Behalf
> Of Willem de Bruijn
> Sent: Monday, August 3, 2026 11:06 PM
> To: [email protected]
> Cc: [email protected]; Nguyen, Anthony L
> <[email protected]>; Hay, Joshua A <[email protected]>;
> Kitszel, Przemyslaw <[email protected]>; Willem de Bruijn
> <[email protected]>
> Subject: [Intel-wired-lan] [PATCH iwl-net v2] idpf: add missing
> cpu_to_le32 in idpf_tx_splitq_build_flow_desc
> 
> From: Willem de Bruijn <[email protected]>
> 
> idpf_tx_splitq_build_flow_desc performs a 32-bit store to &cmd_dtype
> to set the 8-bit cmd_dtype and zero the adjacent 3-byte timestamp
> field in a single operation.
> 
> Descriptors are in little endian. Add missing cpu_to_le32 and cast to
> __le32 to ensure the fields are written correctly also on big endian
> platforms.
> 
> Fixes: 1a49cf814fe1 ("idpf: add Tx timestamp flows")
> Signed-off-by: Willem de Bruijn <[email protected]>
> Reviewed-by: Tony Nguyen <[email protected]>
> 
> ---
> 
> Changes
>   v1 -> v2
>   - add Fixes tag, Tony's Reviewed-by and Cc: intel-wired-
> [email protected]
>   v1: https://lore.kernel.org/netdev/20260731103137.4000876-1-
> [email protected]/
> ---
>  drivers/net/ethernet/intel/idpf/idpf_txrx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/intel/idpf/idpf_txrx.c
> b/drivers/net/ethernet/intel/idpf/idpf_txrx.c
> index c724d429a7aa..91ca75e45463 100644
> --- a/drivers/net/ethernet/intel/idpf/idpf_txrx.c
> +++ b/drivers/net/ethernet/intel/idpf/idpf_txrx.c
> @@ -2408,7 +2408,7 @@ void idpf_tx_splitq_build_flow_desc(union
> idpf_tx_flex_desc *desc,
>  				    struct idpf_tx_splitq_params *params,
>  				    u16 td_cmd, u16 size)
>  {
> -	*(u32 *)&desc->flow.qw1.cmd_dtype = (u8)(params->dtype |
> td_cmd);
> +	*(__le32 *)&desc->flow.qw1.cmd_dtype = cpu_to_le32((u8)(params-
> >dtype
> +| td_cmd));
>  	desc->flow.qw1.rxr_bufsize = cpu_to_le16((u16)size);
>  	desc->flow.qw1.compl_tag = cpu_to_le16(params->compl_tag);  }
> --
> 2.55.0.629.g250fe7f194-goog


Reviewed-by: Aleksandr Loktionov <[email protected]>