Re: [PATCH] net: macb: fix stale data returned by MDIO reads

Andrew Lunn <[email protected]>
Newsgroups org.kernel.vger.netdev,org.kernel.vger.linux-kernel
Message-ID <[email protected]>
> A proper solution would use the IRQ as detection source rather than
> sleep-polling. See BIT 0, called MFD in driver.

Maybe.

The FEC driver used to use interrupts for its MDIO bus. But interrupts
add a lot of overhead. I swapped the FEC to polling and got a
significant speed improvement.

A lot depends on what you have actually doing with the bus. I was
using it in combination with Marvell PHYs, which can give the raw
cable test values, which is a big data set. So the speed up was
welcome. But if all the bus is used for is once per second polls for
link change, a slower bus probably does not matter.

       Andrew
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.