Re: [PATCH v23 net-next 04/12] net/nebula-matrix: add channel layer
Jakub Kicinski <[email protected]>
| Newsgroups | org.kernel.vger.netdev,org.kernel.vger.linux-doc,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On Fri, 31 Jul 2026 17:42:27 +0800 illusion.wang wrote:
> +#define NBL_OPS_CALL(func, para) \
> +do { \
> + typeof(func) _func = (func); \
> + if (_func) \
> + _func para; \
> +} while (0)
Just spotted in the compiler warning -- this macro is definitely not
going to make it upstream. The C coding style of this driver is very
much below the upstream bar, please try to get this reviewed by someone
with upstream experience, or taste, or both.