Re: [PATCH net-next 3/3] net: hns3: use txqueue parameter directly in ndo_tx_timeout

On Fri, Aug 07, 2026 at 03:31:13PM +0800, Jijie Shao wrote:
> 
> on 2026/8/6 19:39, Jijie Shao wrote:
> > 
> > on 2026/8/6 0:52, Simon Horman wrote:

...

> Hi Simon,
> 
> I'd like to note that the actual v2 implementation differs slightly
> from what I described in my previous reply:
> 
> 1. The netif_xmit_timeout_ms() re-check is kept, not dropped.
>  After discussion with colleagues, we decided to preserve the
>  existing behaviour: if the stall has cleared by the time the
>  callback runs, no reset is requested.  This keeps the semantics
>  consistent with the code before this patch.
> 
> 2. The "no netdev TX timeout queue found" branch is also kept,
>  now guarding against txqueue >= num_tqps.
> 
> 3. The bounds check is changed from ndev->num_tx_queues to
>  h->kinfo.num_tqps in this patch rather than a separate bugfix.
>  The OOB has not been encountered in practice, but since the
>  validation is already being rewritten here, folding the fix
>  in avoids an artificial split.
> 
> v2 will be sent shortly.

Thanks for the notes, and your earlier response. They are very helpful.