[PATCH iproute2-next 2/7] ip/routel: follow help vs usage convention

Stephen Hemminger <[email protected]>
Newsgroups org.kernel.vger.netdev
Message-ID <[email protected]>
Similar to update to ip, put help on stdout and usage
on stderr.

Signed-off-by: Stephen Hemminger <[email protected]>
---
 ip/routel | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/ip/routel b/ip/routel
index 09a90126..defe738c 100755
--- a/ip/routel
+++ b/ip/routel
@@ -11,10 +11,11 @@ import getopt
 import subprocess
 
 
-def usage():
+def usage(help=False):
     '''Print usage and exit'''
-    print("Usage: {} [tablenr [raw ip args...]]".format(sys.argv[0]))
-    sys.exit(64)
+    print("Usage: {} [tablenr [raw ip args...]]".format(sys.argv[0]),
+          file=sys.stdout if help else sys.stderr)
+    sys.exit(0 if help else 1)
 
 
 def main():
@@ -23,12 +24,12 @@ def main():
     try:
         opts, args = getopt.getopt(sys.argv[1:], "h46f:", ["help", "family="])
     except getopt.GetoptError as err:
-        print(err)
+        print(err, file=sys.stderr)
         usage()
 
     for opt, arg in opts:
         if opt in ["-h", "--help"]:
-            usage()
+            usage(True)
         elif opt == '-6':
             family = 'inet6'
         elif opt == "-4":
-- 
2.53.0
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.