Re: [PATCH net] net: phylink: treat PSGMII as an inband capable interface
Andrew Lunn <[email protected]>
| Newsgroups | org.kernel.vger.netdev,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On Sat, Aug 08, 2026 at 01:19:37AM +0530, Sandeep Sondagar wrote: > PSGMII (the Qualcomm 5-port SGMII) conveys the link negotiation result > from the PHY back to the MAC through per-channel inband SGMII words, > exactly like SGMII and QSGMII. > > However, PHY_INTERFACE_MODE_PSGMII is missing from > phylink_get_inband_type(), so phylink reports INBAND_NONE for it and > phylink_pcs_neg_mode() falls back to PHYLINK_PCS_NEG_NONE. The PCS is > then programmed in force mode and its control-register speed bits (which > default to 1000base) are used, so a slower copper link - e.g. 100base-T > - is reported as 1Gbps and cannot pass traffic. > > Classify PSGMII alongside SGMII and QSGMII as INBAND_CISCO_SGMII so the > PCS negotiates inband and the resolved link speed comes from the PHY > inband word. > > Signed-off-by: Sandeep Sondagar <[email protected]> If you are targeting net, this needs a Fixes: tag. When did this break? Andrew