Re: [PATCH net] net/sched: cls_api: fix teardown of an adopted proto on insert-race loss
| Newsgroups | org.kernel.vger.netdev |
|---|---|
| Message-ID | <178615141414.2487956.8805241969467933628.git-patchwork-notify@kernel.org> |
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>: On Wed, 5 Aug 2026 10:40:49 -0300 you wrote: > In tc_new_tfilter() the create branch sets tp_created = 1 before calling > tcf_chain_tp_insert_unique(). When the caller loses the race (another > request inserted a proto at the same chain/prio first), insert_unique() > destroys the caller's own tp_new and returns the winner's proto with an > extra reference. tp_created was never cleared, so the loser's errout > path treated the winner's live proto as its own and called > tcf_chain_tp_delete_empty() on it, silently unlinking an active > classifier that the winning request already advertised via > RTM_NEWTFILTER. > > [...] Here is the summary with links: - [net] net/sched: cls_api: fix teardown of an adopted proto on insert-race loss https://git.kernel.org/netdev/net-next/c/d4e359b3608a You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html