Re: [PATCH net] bnxt_en: enable PTM function

Pavan Chebbi <[email protected]>
Newsgroups org.kernel.vger.netdev
Message-ID <CALs4sv17EUFZ8vG_7tC0aDJhVT1NbCk7xnzEET8ZZdoHrPW4ng@mail.gmail.com>
> > Ok I understand you now. Maybe it is fine to have
> > pcie_ptm_enabled()/disabled() called for this version of the driver.
> > Since FW currently always enables it, and these calls are harmless and
> > turn off .getcrosststamp on platforms that don't support PTM, both FW
> > and driver/kernel end up working in sync.
> > Only thing I would argue is should this be done in bnxt_ptp_init() and
> > clear()? Since as much as PTM is a PCIe feature, the cross timestamps
> > are tied with PTP.
>
> It makes sense to have PCIe things tied together, because PTM is PCIe
> feature. Cross timestamps configuration are already in ptp area of the
> driver, so no need to change anything around it

OK. Fine with me.
Reviewed-by: Pavan Chebbi <[email protected]>
Thanks
smime.p7s (application/pkcs7-signature, 5.3 KB) - not displayed
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.