Re: [PATCH net-next v13 03/11] net: phy: add (*notify_phy_attach/detach)() hooks to struct mii_bus

> Worth to notice: As of now phy_detach() is not 100% LIFO symmetric
> to phy_attach_direct(). E.g. sysfs links are torn down before
> suspend while being created before resume. Without reordering of the
> detach function the above mentioned notifier placement is the best
> possible symmetric implementation. For this
> 
> - Relocate code from phy_detach() into phy_detach_internal(). This
>   naming was selected to avoid confusion with "unlocked" helper that
>   usually start with two underscores.

Please could you make this code move a patch of its one. No changes,
just a move.

That makes it easier to review the actual change of calling the
notifier.

We might want to consider the LIFO issue, and add further patches to
sort this out, if it helps with what you are doing here.

    Andrew

---
pw-bot: cr