Re: [PATCH net-next v3 2/3] dt-bindings: net: wiznet,w5100: add link-gpios
Krzysztof Kozlowski <[email protected]>
| Newsgroups | org.kernel.vger.netdev,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On 10/08/2026 09:53, Arnd Bergmann wrote: > On Mon, Aug 10, 2026, at 09:43, Krzysztof Kozlowski wrote: >> On Thu, Aug 06, 2026 at 05:00:01PM +0200, Arthur Crépin Leblond wrote: >>> >>> + link-gpios: >>> + description: >>> + An optional GPIO line that can be wired to the LINKLED pin of the w5500 >>> + as an interrupt to detect link status changes. >> >> The message is confusing. If you describe it from the host (system point >> of view), then interrupts are not GPIOs but "interrupts". >> >> But maybe this is OUT GPIO from the system to the device? > > From the device point of view, it's an LED output, but from the > system side we should describe it as an IRQ_TYPE_EDGE_BOTH > "interrupts" property rather than a gpio line. Then probably we should list all four other pins as well (speed, duplex and active). Best regards, Krzysztof