Re: [PATCH net v2 2/2] net: pse-pd: guard regulator ops against freed PI data during unregister
Kory Maincent <[email protected]>
| Newsgroups | org.kernel.vger.netdev,org.kernel.vger.linux-kernel |
|---|---|
| Organization | bootlin |
| Message-ID | <20260810154327.21e71ae9@kmaincent-XPS-13-7390> |
On Fri, 17 Jul 2026 12:10:43 +0100 Simon Horman <[email protected]> wrote: > This is an AI-generated review of your patch. The human sending this > email has considered the AI review valid, or at least plausible. > https://sashiko.dev/#/patchset/[email protected]?part=2 > --- > --- Patch [2]: [PATCH net v2 2/2] net: pse-pd: guard regulator ops against > freed PI data during unregister --- commit > 651be76b54426e6621f4330232053b29d0731f5d Author: Carlo Szelinsky > <[email protected]> > > net: pse-pd: guard regulator ops against freed PI data during unregister > > The commit tries to fix a use-after-free by clearing pcdev->pi to NULL under > pcdev->lock during unregister, and adding NULL checks in the regulator > operations. All the report from sashiko are either hallucination or possible pre-existing lifetime issue, which is what you are trying to solve. On my side: Reviewed-by: Kory Maincent <[email protected]> Thank you! It would be nice to have it accepted to move forward on your PSE notifier series. Jakub what do you think? Regards, -- Köry Maincent, Bootlin Embedded Linux and kernel engineering https://bootlin.com