Re: [PATCH net-next v5 0/6] hardware pacing offload

Willem de Bruijn wrote:
> From: Willem de Bruijn <[email protected]>
> 
> Enable safe hardware pacing offload on a first device (idpf), plus support.
> 
> - Add rtnetlink support for admin control over the device feature
> - Add device support to the idpf driver
> 
> Besides the main feature, also
> 
> - Small optimization to FQ offload: avoid unnecessary ktime_.._get().
> - Expand so_txtime drv-net test with hw offload testcases.
> - Expand pktgen with txtime feature.
> 
> Details and detailed changelog in the individual patches.
> 
> High level changes:
>   v4 -> v5
>     - Rebase + small kdoc fix only
>   v3 -> v4
>     - Replace ethtool API with rtnetlink
>     - Drop/defer pktgen patch: not essential
> 
> NOTE: the idpf patch will have a minor merge conflict with commit
> "idpf: add missing cpu_to_le32 in idpf_tx_splitq_build_flow_desc"
> (https://lore.kernel.org/netdev/[email protected]/).
> I expect that this series will need another revision, at which point
> that fix will have made its way to net-next. There is also a fix to
> so_txtime.py outstanding, but that is structured so that these do not
> conflict.
> 
> v4: https://lore.kernel.org/netdev/[email protected]/
> v3: https://lore.kernel.org/netdev/[email protected]/
> v2: https://lore.kernel.org/netdev/[email protected]/
> v1: https://lore.kernel.org/netdev/[email protected]/

Claude has some good feedback, that I'll work into a v6.

Mostly minor, but one real regression with v5 in fq_change.