Re: [PATCH] io_uring/zcrx: reject netdevices without ops lock support
Mina Almasry <[email protected]>
| Newsgroups | org.kernel.vger.netdev,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <CAHS8izOmcbyd+y=sQAxRau=Nj7VmoxZLDd00YAGsBEiwyCVCbA@mail.gmail.com> |
On Wed, Aug 5, 2026 at 7:00 AM <[email protected]> wrote: > > From: Yalagada Pavan Kumar <[email protected]> > > zcrx registration can fail for netdevices that do not support the > required ops locking model. > > netdev_queue_get_dma_dev() requires ops locking support. > Calling it for devices without ops lock support triggers > netdev_assert_locked_ops_compat(). > Ha! netif_mp_open_rxq() does check for the ops locking support, but get_dma_dev runs before netif_mpu_open_rxq. I would prefer a fix that doesn't require every caller to add this check. Maybe make the function return -EOPNOTSUPP instead of asserting? Or changing the call sequence so that netif_mp_open_rxq is called before get_dma_dev()? Pavel? -- Thanks, Mina