Re: [PATCH net-next v4 1/3] dt-bindings: net: wiznet,w5100: convert to DT schema

Arthur Crépin Leblond <[email protected]> Tue, 11 Aug 2026 16:14:57 +0200

Newsgroups	org.kernel.vger.netdev,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel
Message-ID	<ansuYaT2GAMAA0hF@pc-du-fromage>

On Tue, Aug 11, 2026 at 02:57:40PM +0200, Arnd Bergmann wrote:
>On Tue, Aug 11, 2026, at 14:34, Arthur Crépin Leblond wrote:
>> +        ethernet@0 {
>> +            compatible = "wiznet,w5500";
>> +            reg = <0>;
>> +            pinctrl-names = "default";
>> +            pinctrl-0 = <&eth1_pins>;
>> +            interrupt-parent = <&gpio>;
>> +            interrupts = <25 IRQ_TYPE_EDGE_FALLING>;
>
>I think this needs to be IRQ_TYPE_EDGE_BOTH instead of IRQ_TYPE_EDGE_FALLING
>to make sense.
>
>      Arnd

This interrupt is for the main one which is active low, we don't need
to catch the rising one.
Only The link interrupt needs to be both edges.

Arthur