Re: [PATCH net v4 0/4] net: phy: dp83640: fix shared clock lifetime and probe error cleanup
luoxuanqiang <[email protected]>
| Newsgroups | org.kernel.vger.netdev |
|---|---|
| Message-ID | <[email protected]> |
Hi Richard, 在 2026/8/11 21:11, Richard Cochran 写道: > On Fri, Aug 07, 2026 at 03:07:25PM +0800, [email protected] wrote: >> From: Xuanqiang Luo <[email protected]> >> >> The DP83640 driver shares one PTP clock between all PHYs on the same MII >> bus. >> >> Its driver-local clock lookup and removal scheme can leak the shared clock >> on probe failure or free it while another probe is acquiring it. > Is this an actual problem that you have seen in the real world? > > Thanks, > Richard No, I have not observed this on real hardware. I found both issues by code inspection. The probe error path has a definite resource leak, while the concurrent probe/remove path has a potential race. I have not reproduced the latter. Thanks, Xuanqiang