Re: [PATCH net] bnxt_en: enable PTM function

On 08/08/2026 05:39, Pavan Chebbi wrote:
>>> Ok I understand you now. Maybe it is fine to have
>>> pcie_ptm_enabled()/disabled() called for this version of the driver.
>>> Since FW currently always enables it, and these calls are harmless and
>>> turn off .getcrosststamp on platforms that don't support PTM, both FW
>>> and driver/kernel end up working in sync.
>>> Only thing I would argue is should this be done in bnxt_ptp_init() and
>>> clear()? Since as much as PTM is a PCIe feature, the cross timestamps
>>> are tied with PTP.
>>
>> It makes sense to have PCIe things tied together, because PTM is PCIe
>> feature. Cross timestamps configuration are already in ptp area of the
>> driver, so no need to change anything around it
> 
> OK. Fine with me.
> Reviewed-by: Pavan Chebbi <[email protected]>
> Thanks

Jakub, it looks like we have to drop fixes tag and apply it to net-next
as it has never worked on upstream kernel.

Sashiko's comments are not really valuable - underflow of
ptm_enabled_cnt may happen only right before the device structure is
freed, so it actually doesn't matter, all other drivers do not care
about ptm counter as well on destroy path. And validating result of
pci_enable_ptm() also makes no sense because we don't care about the
result, only thing we can do is to put debug message, but that can also
be figured out in run-time.