Re: [PATCH V2 RFC 2/2] ARM: dts: BCM5301X: change Luxul XWR-3150 CPU port from 5 do 8
Andrew Lunn <[email protected]>
| Newsgroups | org.kernel.vger.netdev,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-devicetree |
|---|---|
| Message-ID | <[email protected]> |
> Change the choice of "cpu" port to 8 and make the third Ethernet > interface (connected to port 8) use MAC designed for the first Ethernet > interface (connected to port 5). This makes Linux use switch in a > feature full way. > This seems to be a slight abuse of DT. Instead of describing hardware we > make it steer Linux into using a more appropriate switch port. This > isn't strictly a setback on its own. It's a change from one choice to > another. It is a bit fuzzy, but the hardware of port 8 is better designed for the function of being the CPU port. We are expressing this hardware property via actually using it as the CPU port. > I'm not sure about that MAC however. We say that the third Ethernet > interface should use MAC that was designed for the first one. > > Is all of that acceptable? > > .../arm/boot/dts/broadcom/bcm47094-luxul-xwr-3150-v1.dts | 9 +++++++-- Is this the only device in mainline which is affected? Andrew