Re: [PATCH net-next v9] net: phy: Add driver for Motorcomm Quad 2.5GbE phy

> [Severity: High]
> Does swapping the global register space and then releasing the mdio bus lock
> expose other generic phylib operations to silent data corruption?

I would suggest you look at how EEE is handled. phylib often goes
direct to the hardware and accesses the registers, without calling
into the driver first. So it is missing the lock you just added.

I would suggest you audit phylib and see if there are other cases
where it calls genphy_ functions, e.g if the driver does not provide a
method in phy_driver.

     Andrew