Re: [PATCH v3 net-next 05/15] neighbour: Remove __rcu from neigh_tables[].

On Tue, Aug 11, 2026 at 7:42 AM David Ahern <[email protected]> wrote:
>
> On 8/10/26 8:23 PM, Kuniyuki Iwashima wrote:
> > diff --git a/net/core/neighbour.c b/net/core/neighbour.c
> > index 6fda0052027b..caa52bf64a2d 100644
> > --- a/net/core/neighbour.c
> > +++ b/net/core/neighbour.c
> > @@ -3162,7 +3157,7 @@ int neigh_xmit(int index, struct net_device *dev,
> >               struct neighbour *neigh;
> >
> >               rcu_read_lock();
>
> rcu_read_lock can be moved down after this check.

I'll keep it as patch 7 adds dev_net_rcu() here.

>
>
> > -             tbl = rcu_dereference(neigh_tables[index]);
> > +             tbl = neigh_tables[index];
> >               if (!tbl) {
> >                       rcu_read_unlock();
> >                       goto out_kfree_skb;
>
> Reviewed-by: David Ahern <[email protected]>
>

Thanks !