Re: [PATCH net] octeontx2-af: initialize lmac_bmap in rvu_mcs_set_lmac_bmap()
Ratheesh Kannoth <[email protected]>
| Newsgroups | org.kernel.vger.netdev,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <anwTi3zKvZI3DuNe@rkannoth-OptiPlex-7090> |
On 2026-08-12 at 11:37:30, Karl Mehltretter ([email protected]) wrote: > rvu_mcs_set_lmac_bmap() declares lmac_bmap without initializing it and > only sets bits for valid lmacs with set_bit(), which ORs into the word > without clearing it first. Bits for invalid or skipped ports keep > whatever was on the stack, and the garbage is stored into > mcs->hw->lmac_bmap. > > Initialize lmac_bmap to 0 so only valid lmacs are marked. > > Found with Clang's -Wconditional-uninitialized. > > Fixes: ca7f49ff8846 ("octeontx2-af: cn10k: Introduce driver for macsec block.") > Assisted-by: Claude:claude-fable-5 > Signed-off-by: Karl Mehltretter <[email protected]> Thank you. Reviewed-by: Ratheesh Kannoth <[email protected]>