Re: [TEST] google runner needs nested cases
Sheena Mohan <[email protected]>
| Newsgroups | org.kernel.vger.netdev |
|---|---|
| Message-ID | <CADWJPTsC5GA=tefJjiZ5mCo2xAm+K2OuKng+BUf4=_kW4hacvA@mail.gmail.com> |
On Tue, Aug 4, 2026 at 10:39 AM Sheena Mohan <[email protected]> wrote: > > On Tue, Aug 4, 2026 at 7:25 AM Jakub Kicinski <[email protected]> wrote: > > > > On Tue, 28 Jul 2026 10:07:15 -0700 Sheena Mohan wrote: > > > The recent updates have been merged, and the tests should now report > > > sub-case results. > > > Please let us know if any further improvements are needed. > > > > It doesn't look right. > > > > https://gve-netdev-nipa.static.usercontent.goog/json/results-202608040108-88cb54ab-ca48-426b-9c9a-50bfbb0de32a.json > > > > test "napi-threaded-py" > > group "selftests-drivers-net" > > result "pass" > > ^^^^^^^^^^^^^ > > link "https://gve-netdev-nipa.static.usercontent.goog/results/202608040108-88cb54ab-ca48-426b-9c9a-50bfbb0de32a/napi-threaded-py/logs.html" > > time 20.788391 > > > > # selftests: drivers/net: napi_threaded.py > > not ok 1 selftests: drivers/net: napi_threaded.py # exit=1 > > # Totals: pass:0 fail:1 xfail:0 xpass:0 skip:0 error:0 > > # not ok 1 napi_threaded.napi_init > > # not ok 2 napi_threaded.change_num_queues > > # not ok 3 napi_threaded.enable_dev_threaded_disable_napi_threaded > > > > Does not look like a pass at all. Subcases not in JSON. > > Not sure why the subcases are listed under the main return > > in the output, I've never seen that. > > > > > > test "psp-py" > > group "selftests-drivers-net" > > result "pass" > > link "https://gve-netdev-nipa.static.usercontent.goog/results/202608040108-88cb54ab-ca48-426b-9c9a-50bfbb0de32a/psp-py/logs.html" > > time 341.833939 > > > > # selftests: drivers/net: psp.py > > not ok 1 selftests: drivers/net: psp.py # exit=1 > > # Totals: pass:0 fail:1 xfail:0 xpass:0 skip:0 error:0 > > > > Again, doesn't seem to be a pass?? > > > > > > test "queues-py" > > group "selftests-drivers-net" > > result "pass" > > link "https://gve-netdev-nipa.static.usercontent.goog/results/202608040108-88cb54ab-ca48-426b-9c9a-50bfbb0de32a/queues-py/logs.html" > > time 686.483495 > > results > > test "queues-check-xsk" > > result "pass" > > > > Okay, here we have a subcase.. > > > > # selftests: drivers/net: queues.py > > ok 1 selftests: drivers/net: queues.py > > # Totals: pass:1 fail:0 xfail:0 xpass:0 skip:0 error:0 > > check_down > > # ok 4 queues.check_xsk > > # # Totals: pass:4 fail:0 xfail:0 xpass:0 skip:0 error:0 > > > > But why only one? What happened to the other 3 that ksft clearly saw > > since it enumerated check_xsk as the fourth?? > > > > > > Something is mangling the output on your runner, it seems. > > And the parsing seems off. > Thanks for bringing this to our attention. We will look into the > parsing issues and work on getting this fixed. Latest test results should now cleanly report subtest results.