[PATCH net v6 4/4] net: ethernet: oa_tc6: Fix for the wrong data type
Selvamani Rajagopal via B4 Relay <[email protected]>
| Newsgroups | org.kernel.vger.netdev,org.kernel.feeds.b4-sent,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <20260812-fix-race-condition-and-crash-v6-4-6cf90f4a271a@onsemi.com> |
From: Selvamani Rajagopal <[email protected]> Inadvertently bool data type is used where int is supposed to be used. This might turn a negative error code into true or false and sign of the return code would be lost. Fixes: 8f9bf857e43b ("net: ethernet: oa_tc6: implement internal PHY initialization") Signed-off-by: Selvamani Rajagopal <[email protected]> --- changes in v6 - No change changes in v5 - New patch. Fixed the wrong data type used. --- drivers/net/ethernet/oa_tc6.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/oa_tc6.c b/drivers/net/ethernet/oa_tc6.c index 5354ed3ece7e..6e27ed39a99b 100644 --- a/drivers/net/ethernet/oa_tc6.c +++ b/drivers/net/ethernet/oa_tc6.c @@ -423,7 +423,7 @@ static int oa_tc6_mdiobus_read(struct mii_bus *bus, int addr, int regnum) { struct oa_tc6 *tc6 = bus->priv; u32 regval; - bool ret; + int ret; ret = oa_tc6_read_register(tc6, OA_TC6_PHY_STD_REG_ADDR_BASE | (regnum & OA_TC6_PHY_STD_REG_ADDR_MASK), -- 2.43.0