Re: [PATCH net-next] ionic: Add .get_fec_stats ethtool handler
Eric Joyner <[email protected]>
| Newsgroups | org.kernel.vger.netdev |
|---|---|
| Message-ID | <[email protected]> |
On 8/4/2026 3:27 AM, Vadim Fedorenko wrote: > Caution: This message originated from an External Source. Use proper caution > when opening attachments, clicking links, or responding. > > > On 31/07/2026 22:40, Eric Joyner wrote: >> Reports FEC statistics totals and an 802.3ck FEC histogram. Per-lane counts >> currently aren't supported, and the only expected histogram format from >> firmware is the one with 16 bins from RS(544,514) FEC. > > does it mean the FW will return IONIC_STAT_INVALID for 100G CWDM4 mode > on newest devices? > > The only device we have that supports reporting these FEC histograms doesn't have a PHY that supports 100G CWDM4; the IP block for it only supports PAM4 media types and not NRZ. So for now, it would return IONIC_STAT_INVALID for that mode. Though, I don't know if that'll be the case for future devices; maybe they will support FEC histogram stat collection with NRZ media that has fewer than 16 histogram bins. I just don't know if it's worth supporting that possibility right now since I don't know when or if that will happen. - Eric