Re: [PATCH net-next 0/2] net: fec: support RX flushing via fsl,rx-flush-queues
"Sverdlin, Alexander" <[email protected]>
| Newsgroups | org.kernel.vger.netdev,dev.linux.lists.imx,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
Thanks for the quick feedback, Andrew! On Fri, 2026-08-14 at 15:56 +0200, Andrew Lunn wrote: > > The FEC/ENET controller can flush frames that get stuck at the head of the > > RX FIFO because their destination ring has no empty buffer descriptor > > (RxBD[E] clear or ENET_RDARn not set). Without flushing, such a frame blocks > > the FIFO and stalls reception on all queues; with flushing enabled the > > offending frame is discarded instead. Flushing is configured per RX queue > > through the RX_FLUSHn bits of the QOS Scheme register (FEC_QOS_SCHEME). > > > > This series adds a device tree property, fsl,rx-flush-queues, listing the RX > > queues for which flushing should be enabled, and programs the corresponding > > RX_FLUSHn bits. > > DT described hardware, not policy for how hardware is configured. > > Maybe use an ethtool private flags? Makes sense to me, I'll rework! -- Alexander Sverdlin Siemens AG www.siemens.com