Re: [PATCH net-next] ionic: Add .get_fec_stats ethtool handler
Eric Joyner <[email protected]>
| Newsgroups | org.kernel.vger.netdev |
|---|---|
| Message-ID | <[email protected]> |
On 8/14/2026 12:05 PM, Jakub Kicinski wrote: > Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. > > > On Fri, 31 Jul 2026 14:40:21 -0700 Eric Joyner wrote: >> Reports FEC statistics totals and an 802.3ck FEC histogram. Per-lane counts >> currently aren't supported, and the only expected histogram format from >> firmware is the one with 16 bins from RS(544,514) FEC. > > To be clear this patch is now too old for us to process, you need to > repost. Before you do - double check the 'shiko, it has things to say: > https://netdev-ai.bots.linux.dev/sashiko/#/patchset/[email protected] Ok, I'll address the Sashiko review comments and resubmit. But a couple questions: the Sashiko instance at this site looks like it's doing more review than what the Sashiko bot at sashiko.dev does; should I be checking this site for Sashiko reviews instead? As well, I don't think the upstream Sashiko repository has support for cross-reviewing; is this site running on a custom version or some early unreleased code? - Eric