Re: [PATCH net-next] net: xdp: don't assume an Ethernet header in generic XDP
Jakub Kicinski <[email protected]>
| Newsgroups | org.kernel.vger.netdev,org.kernel.vger.bpf,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On Thu, 13 Aug 2026 19:32:24 +0800 Jiayuan Chen wrote:
> Refusing to attach XDP to L3 devices instead would not help: mac_len is a
> property of the skb, not of the netdev, so an ARPHRD_ETHER device can see
> mac_len == 0 too.
Let's try. There is no native XDP on any non-ether device, making
generic xdp work on those is silly. Just attach the BPF in TC.
AI says that one example for mac_len=0 packet on ether device is IP
mcast loopback, which should not go via generic XDP in the first place.
> Fixes: 22b6034323fd ("net, xdp: Update pkt_type if generic XDP changes unicast MAC")
Please don't send fixes to net-next :|
--
pw-bot: cr