Re: [PATCH net-next 10/11] bnge: add aRFS flow steering ndo support
Jakub Kicinski <[email protected]>
| Newsgroups | org.kernel.vger.netdev,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On Fri, 14 Aug 2026 06:44:34 +0530 Vikas Gupta wrote:
> Introduce the ndo_rx_flow_steer callback (bnge_rx_flow_steer) to
> support aRFS.
> This callback creates an NTUPLE filter that steers matching packets
> to the appropriate RX queue. The implementation dissects flow keys
> from the SKB, creates an NTUPLE filter with the associated L2 filter,
> inserts it into the NTUPLE hash table, and schedules the sp_task
> workqueue via BNGE_RX_NTP_FLTR_SP_EVENT to program the filter
> in the firmware.
> Add bnge_cfg_ntp_filters() called from the periodic timer via sp_task
> to handle deferred filter programming and expiration via
> rps_may_expire_flow().
This one is not transient:
drivers/net/ethernet/broadcom/bnge/bnge_netdev.c:3168:17: warning: result of comparison of constant 18446744073709551615 with expression of type 'u32' (aka 'unsigned int') is always false [-Wtautological-constant-out-of-range-compare]
3168 | if (filter_id == BNGE_FLTR_ID_INVALID)
| ~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~