Re: [PATCH net-next v11] net: phy: Add driver for Motorcomm Quad 2.5GbE phy
Andrew Lunn <[email protected]>
| Newsgroups | org.kernel.vger.netdev,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
> + if (link) {
> + phydev->link = 1;
> + phydev->pause = !!(lpa & BIT(10));
> + phydev->asym_pause = !!(lpa & BIT(11));
This is wrong.
Where do you see any other driver doing this?
phy_resolve_aneg_pause() will set phydev->pause and
phydev->asym_pause.
You should be trying to use genphy_read_status() to do most of the
work, and then mix in the 2.5G status information afterwards.
Andrew