Re: [PATCH net] bnxt_en: Gate TPH enablement behind BNXT_SUPPORTS_QUEUE_API check

On Thu, 20 Aug 2026 14:29:55 -0400 Thomas Walsh wrote:
> On Thu, Aug 20, 2026 at 2:16 PM Jakub Kicinski <[email protected]> wrote:
> > On Thu, 20 Aug 2026 13:55:57 -0400 Thomas Walsh wrote:  
> > > In this particular situation, the customer had very recently upgraded their
> > > firmware. "RX queue restart failed: err=-95" messages were still observed.  
> >
> > Would you be able to share the NIC and the FW version?  
> 
> NIC is BCM57414 NetXtreme-E 10Gb/25Gb RDMA Ethernet Controller
> [14e4:16d7]
> FW version shared with us was 238.1.138.6 upgraded from 236.1.167.0
> 
> > Could it be that they upgraded to a version which has TPH but not queue
> > resets yet?  I _think_ queue resets came in 232.x but maybe there were
> > bugs which delayed it later.  
> 
> I suspected something similar initially, but both of the versions are
> _relatively_ recent AFAICT.  

Ugh, apparently :( I would have thought nobody is buying BCM574xx

> Which lead us to graceful handling of pcie_enable_tph()

Either way, I still agree with your approach.
Let's see if Pavan and Michael feel strongly.