Re: [PATCH net] bnxt_en: Gate TPH enablement behind BNXT_SUPPORTS_QUEUE_API check
Jakub Kicinski <[email protected]>
| Newsgroups | org.kernel.vger.netdev,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On Thu, 20 Aug 2026 12:16:07 -0700 Michael Chan wrote: > On Thu, Aug 20, 2026 at 11:59 AM Michael Chan <[email protected]> wrote: > > > > On Thu, Aug 20, 2026 at 11:30 AM Thomas Walsh <[email protected]> wrote: > > > NIC is BCM57414 NetXtreme-E 10Gb/25Gb RDMA Ethernet Controller > > > [14e4:16d7] > > > FW version shared with us was 238.1.138.6 upgraded from 236.1.167.0 > > > > This NIC does not support queue management. I think it also doesn't > > support TPH, but I need to check and confirm. > > Confirmed. Only Thor and newer (P5_PLUS) supports TPH. > > So the patch looks fine to me. TPH requires queue management to > restart the queue. And NICs that support queue management (with > updated FW) all support TPH. Thanks. > > Reviewed-by: Michael Chan <[email protected]> Thanks! Thomas, please update commit msg with the info from Michael, rebase on up-to-date net/main and repost. -- pw-bot: cr