Re: [PATCH 0/4] net: broadcom: Improve IRQ error handling
Bui Duc Phuc <[email protected]>
| Newsgroups | org.kernel.vger.netdev,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <CAABR9nEA1nu9DyXDDqYS2oSi+zzR1e5Z9C+WqEsxE-jX83=xPA@mail.gmail.com> |
Hi Andrew,
Thank you for your feedback.
>
> > What about -EPROBE_DEFER? Do you also want to ignore it and not
> > give the driver a chance to probe again?
>
> Please do some git research. How long has the code been this way?
>
> If -EPROBE_DEFER was a problem, why has nobody reported it?
>
I did some git research as suggested and found commit 6b77c06655b8
("net: bcmgenet: Check for Wake-on-LAN interrupt probe deferral") written
by Florian back in 2022:
https://lore.kernel.org/r/[email protected]
In that commit, Florian specifically highlighted that the interrupt
controller (irq-bcm7038-l1.c) might be probed after the Ethernet driver,
requiring an explicit check for -EPROBE_DEFER to ensure the interrupt is
eventually fetched.
This commit clearly shows that probe deferral and IRQ lookup issues on these
Broadcom controllers are real-world problems rather than theoretical edge cases.
Best regards,
Phuc