Re: [PATCH] pptp: reject payloads shorter than the PPP protocol field
Chuyf26 <[email protected]>
| Newsgroups | org.kernel.vger.netdev |
|---|---|
| Message-ID | <[email protected]> |
Simon, thanks for the review. Your concern is valid: payload_len is only a lower bound since the skb is never trimmed to headersize + payload_len, so bounding the new checks by the peer-advertised value instead of the bytes actually present (skb->len - headersize) would indeed change the receive behaviour for a peer that under-reports payload_len, as you described. Given that, and that this duplicates the earlier pptp patch from Zhixing Chen which carries the same concern, I am withdrawing this patch rather than posting a v2. Sorry for the noise. Chuyf26