Re: [PATCH net v2] net: amd-xgbe: support receiving packets with bad FCS

On Wed, Aug 19, 2026 at 07:16:56PM +1000, James wrote:
> amd-xgbe driver currently sets the MAC_RCR.DCRCC bit whenever RX is
> enabled. This disables hardware FCS validation, causing packets with
> bad FCS to be accepted unconditionally.
> 
> This change unsets DCRCC so that packets with bad FCS will be dropped,
> in-line with typical behaviours of many other network controllers.
> 
> Tests:
> - Verified that packets with bad FCS are now dropped.
> - Verified that receiving packets with bad FCS will increment the
>   `rx_crc_errors` counter.
> 

Hi James,

I think this warrants a fixes tag
(no blank line between it and your signed-off-by line).

Fixes: c5aa9e3b8156 ("amd-xgbe: Initial AMD 10GbE platform driver")

> Signed-off-by: James Nugraha <[email protected]>

net:amd-xgbe: discard rx packets with bad FCS

> ---
> Changes in v2:
> - Eliminated DCRCC toggling via RXALL: now it simply sets the
>   correct default value on MAC Rx enable
>  drivers/net/ethernet/amd/xgbe/xgbe-dev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

I think you may have forgotten to update the patch description
as per the suggestion made by David in his review of v1.

	net: amd-xgbe: discard rx packets with bad FCS

And, some points on process:

* Please post updated versions of patches
  as separate threads rather than as respones to earlier versions.

* Please make sure the author of the patch matches the signed off by line.
  You can do this by updating the from address in the email. Or
  if that is not possible add an extra From: line at exactly
  the first line of the body of the email.

Thanks!

-- 
pw-bot: changes-requested