Re: [PATCH net] net/sched: sch_teql: restore skb->dev on the slave failure path

Jakub Kicinski <[email protected]>
Newsgroups org.kernel.vger.netdev
Message-ID <[email protected]>
On Fri, 21 Aug 2026 12:04:12 -0400 Jamal Hadi Salim wrote:
> > This is an AI-generated review of your patch. The human sending this
> > email has considered the AI review valid, or at least plausible.
> > ---
> > net/sched: sch_teql: restore skb->dev on the slave failure path
> >
> > teql_master_xmit() used to leave skb->dev pointing at a slave after that
> > slave's ndo_start_xmit() failed, so the skb could end up queued on a later
> > slave's neighbour arp_queue while referring to the earlier slave.  The
> > patch restores skb->dev to the master device at the end of each slave
> > iteration.
> >  
> 
> Let's please apply this patch. The patch correctly fixes the reported
> UAF (namespace-reachable, slave deleted while skb queued on another
> slave's neighbour).

It's way too old now, just repost if you think it's good as is.
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.