Re: [PATCH net v4] net: wwan: qcom_bam_dmux: fix TX DMA channel use-after-free
Hongyan Xu <[email protected]>
| Newsgroups | org.kernel.vger.netdev,org.kernel.vger.linux-arm-msm,org.kernel.vger.stable |
|---|---|
| Message-ID | <[email protected]> |
Hi Stephan, Thanks for the detailed review. I addressed the comments in v4: - Replace pc_vote, pc_vote_acked, and pc_down_pending with the four-state bam_dmux_pc_vote enum. - Remove the redundant dmux->rx check in bam_dmux_handle_pc(). - Use guard(mutex)() in runtime PM paths and devm_mutex_init() in probe. - Let runtime_suspend() handle cleanup when runtime_resume() cannot acquire the TX channel, instead of calling bam_dmux_power_off() there. - Request both state IRQs with IRQF_NO_AUTOEN, enable them only after the initial probe state is committed, and disable both before final remove cleanup. The v4 patch is attached. Regards, Hongyan