Re: [PATCH] net: sunplus: fix tx_poll spin_lock missing irqsave in NAPI context

Jakub Kicinski <[email protected]>
Newsgroups org.kernel.vger.netdev,org.infradead.lists.linux-arm-kernel
Message-ID <[email protected]> 
On Thu, 20 Aug 2026 15:01:59 +0200 Andrew Gaylard wrote:
> spl2sw_tx_poll() runs in NAPI (softirq) context and acquires
> comm->tx_lock with plain spin_lock(). The hardirq handler
> spl2sw_ethernet_interrupt() acquires the same lock, so a hardirq on
> the same CPU while the NAPI poll holds the lock would deadlock with
> IRQs disabled. Use spin_lock_irqsave/spin_unlock_irqrestore.

Please explain how the issue was found and how the fix was tested.
I mean - this is an ancient driver, if you don't have a way to test the
fix you should not be sending the patch.
-- 
pw-bot: cr
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.