Re: [PATCH net-next 5/6] netlink: specs: rt-route: describe lwt BPF program options

On Fri, Sep 18, 2026 at 06:36:55AM +0000, [email protected] wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] netlink: specs: build failure due to missing header in lwt-bpf-prog
> --
> 
> commit 73e4e6736fda4554b1e22b6360a42d9d2e02b4dc
> Author: Hangbin Liu <[email protected]>
> 
> netlink: specs: rt-route: describe lwt BPF program options
> 
> This replaces binary BPF attributes with a nested lwt-bpf-prog attribute
> to support lwt bpf prog options.
> 
> > diff --git a/Documentation/netlink/specs/rt-route.yaml b/Documentation/netlink/specs/rt-route.yaml
> > index 6030d7cb8d0d1..5e9537f7dfad4 100644
> > --- a/Documentation/netlink/specs/rt-route.yaml
> > +++ b/Documentation/netlink/specs/rt-route.yaml
> 
> [ ... ]
> 
> > @@ -610,6 +614,16 @@ attribute-sets:
> >        -
> >          name: hwid
> >          type: u8
> > +  -
> > +    name: lwt-bpf-prog
> > +    name-prefix: lwt-bpf-prog-
> > +    attributes:
> 
> [Severity: Low]
> Will this cause a build failure in the generated YNL tools due to a missing
> header?
> 
> Because the header property is omitted for the lwt-bpf-prog attribute set,
> the YNL code generator will automatically output the C enumerators
> LWT_BPF_PROG_FD and LWT_BPF_PROG_NAME in its generated header.
> 
> Other attribute sets in this spec correctly specify header: linux/lwtunnel.h,
> which causes the generated YNL header to globally include it. Since the
> kernel header linux/lwtunnel.h already defines LWT_BPF_PROG_FD and
> LWT_BPF_PROG_NAME, compiling the userspace YNL tools will result in a fatal
> redefinition error.
> 
> Should a header property mapping to linux/lwtunnel.h be added here?

Yes, I will do it.