Re: [PATCH net v8 2/4] net: usb: smsc95xx: register the PHY interrupt with the MDIO bus
Aleksei Sviridkin <[email protected]>
| Newsgroups | org.kernel.vger.netdev,org.kernel.vger.linux-kernel,org.kernel.vger.linux-usb |
|---|---|
| Message-ID | <[email protected]> |
> > + pdata->mdiobus->irq[pdata->phydev->mdio.addr] = phy_irq; > > pdata->phydev->irq = phy_irq; > > Looking at just the information here it looks like this line can be > deleted? Yes, once the table is filled before mdiobus_register() instead of after phy_find_first(): phy_device_create() seeds phydev->irq from the table at scan time, and as written that still happens with PHY_POLL in it. phy_irq exists before the bus is even allocated, so v9 moves the fill ahead of the registration, for every address since the PHY's address is not known until the scan, and deletes this line. Same shape in 1/4.