Re: [PATCH net 7/8] net: bcmgenet: zero-initialize Transmit Status Block in bcmgenet_add_tsb
Nicolai Buchwitz <[email protected]>
| Newsgroups | org.kernel.vger.netdev,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
Hi Florian On 18.9.2026 02:07, Florian Fainelli wrote: > bcmgenet_add_tsb() pushes 64 bytes of headroom onto the skb to form the > Transmit Status Block (TSB) but only assigns status->tx_csum_info when > skb->ip_summed == CHECKSUM_PARTIAL. For packets without checksum > offload, > or for other fields within struct status_64, the status block contains > uninitialized stack/heap memory from previous skb operations. The MAC only reads tx_csum_info when the descriptor has DMA_TX_DO_CSUM, and bcmgenet_xmit() sets that only for CHECKSUM_PARTIAL. The stale value seems to be never used? Did you hit an actual failure? Otherwise this would be a 64 byte memset on every transmitted packet. > [...] Thanks, Nicolai