Re: [RFT PATCH -perfbook 0/2] Retouch plots in QQA 15.31

On Tue, Jan 30, 2024 at 09:57:06AM -0800, Paul E. McKenney wrote:
> On Wed, Jan 31, 2024 at 12:31:06AM +0900, Akira Yokosawa wrote:
> > Hi Paul,
> > 
> > I'm not sure if you are already working on those figures in .png,
> > but I'm sending updates in scripts.  I'm dropping changes and
> > additions of .eps and .png files generated by the updated scripts.
> > 
> > Here is a list of commands you'd need to reflect the changes in
> > perfbook.pdf.
> > 
> >     pushd CodeSamples/cpu/data/kerneltest009.05.atn6.2024.01.17-08.25.02/
> 
> I removed this directory due to my having tweaked the data to paper over
> bugs in early versions of my scripts.  So I focused instead on
> CodeSamples/cpu/data/kerneltest054.05.atn6.2024.01.22-12.28.01.
> 
> Ah, and I never did push out the commit where I removed the
> CodeSamples/cpu/data/kerneltest009.05.atn6.2024.01.17-08.25.02
> directory.  Apologies, and it is out there now.
> 
> >     sh plots.sh
> 
> This failed until I installed the groff package to get pfbtops.
> I of course also had to move expand.pl to this directory.
> 
> >     evince coe-nvalue.eps &
> >     evince coe.eps &
> >     evince fre.eps &
> >     evince rfe.eps &
> >     display fre.png &
> 
> I do like the vertical dashed line at x=0.  I see artifacts on my
> screen due to pixel/plot misalignment, but increasing size makes
> things look good.  It will be fine on paper.  And the fill is
> good compared to the funny datapoint labels.
> 
> I adjusted coe.eps's xrange to include the entire curve in the plot.
> 
> And it does look a lot more professional than my original, so thank
> you for that!
> 
> > If those plots look reasonable to you, please copy them to the parent
> > directory and do the "make":
> > 
> >     cp *.eps fre.png ../
> 
> I don't understand why fre.png is needed.  I am leaving it out, so
> perhaps I will learn the hard way.  ;-)
> 
> >     popd
> >     make
> > 
> > If those figures in the resulting perfbook.pdf looks good to you,
> > I'd like you to go forward and commit the changes and additions:
> > 
> >     git add CodeSamples/cpu/data/kerneltest009.05.atn6.2024.01.17-08.25.02/*.eps
> >     git add CodeSamples/cpu/data/kerneltest009.05.atn6.2024.01.17-08.25.02/fre.png
> >     git add CodeSamples/cpu/data/*.eps
> >     git add CodeSamples/cpu/data/fre.png
> > 
> >     git commit -a # with a suitable tag such as Requested-by: me
> > 
> > Furthermore, if you think those .png figures, now obsoleted by the
> > new .eps figures, are not needed anymore, please "git rm" them as well.
> 
> Done.
> 
> I kept the old .png files where they are generated because I did not
> remove that part of the plots.sh file.  Showing both ways of doing
> this is not necessarily a bad thing.  ;-)
> 
> > If there is anything I've missed, please let me know.
> 
> Queued and pushed, thank you!

Except that github choked on the 366MB coe.out file.  The gzip command
compresses it to 72MB, and "tar -cJf" gets it down to 33MB, so maybe I
rebase the compressed version into the commit that created that file.

And change the script that collects the data to do the compression.  ;-)

Now kernel.org had no problem with the full file, but it might also
be good to avoid imposing too much on their storage-space largesse...

Other thoughts?

							Thanx, Paul

> >         Thanks, Akira
> > --
> > Akira Yokosawa (2):
> >   CodeSamples/cpu/data: plots.sh: Fix typo in xlabel for fre plot
> >   CodeSamples/cpu/data: Use "smooth frequency" for plotting histogram
> > 
> >  .../expand.pl                                 | 42 +++++++++
> >  .../plots.sh                                  | 85 ++++++++++++++++++-
> >  2 files changed, 126 insertions(+), 1 deletion(-)
> >  create mode 100755 CodeSamples/cpu/data/kerneltest009.05.atn6.2024.01.17-08.25.02/expand.pl
> > 
> > 
> > base-commit: 9caac64bfabf85439c480ce928dddef969354369
> > -- 
> > 2.34.1
> > 
> >