Re: [PATCH] precheck-tentative.sh: Make array.sty probing fail-fast and deterministic
"Paul E. McKenney" <[email protected]> Thu, 7 May 2026 10:52:25 -0700
| Newsgroups | org.kernel.vger.perfbook |
|---|---|
| Message-ID | <fa82e08b-eeff-4b43-be7d-10a92f079eab@paulmck-laptop> |
On Thu, May 07, 2026 at 07:37:48PM +0900, Akira Yokosawa wrote:
> Hi,
>
> On Thu, 7 May 2026 17:50:11 +0800, Kunwu Chan wrote:
> > On systems where kpsewhich cannot resolve array.sty, the script fed an
> > empty path into the version-parsing pipeline and then compared an empty
> > array_req_ver against latex_ver in the non-pdflatex-dev path. The
> > result depended on environment and produced no actionable error.
> >
> > This is reproducible by overriding kpsewhich to return nothing for
> > array.sty while keeping other lookups intact.
> >
> > Add a guard before parsing array.sty, set array_req_ver only when the
> > file exists, fail fast with a clear diagnostic when it does not, and
> > correct the warning text typo ("arary.sty" -> "array.sty").
> >
> > Fixes: 4cad3dd1174a ("precheck-tentative.sh: Fail early with suggestions for Fedora 44")
> >
> > Signed-off-by: Kunwu Chan <[email protected]>
> > ---
> > utilities/precheck-tentative.sh | 19 ++++++++++++++-----
> > 1 file changed, 14 insertions(+), 5 deletions(-)
> >
>
> I didn't think of running "make" before installing texlive-tools bundle.
> That said, this can be helpful in setting up brand new installations.
> And thanks for the typo fix!
>
> Acked-by: Akira Yokosawa
Queued and pushed, thank you both!
Thanx, Paul
> Regerds, Akira
>
> > diff --git a/utilities/precheck-tentative.sh b/utilities/precheck-tentative.sh
> > index 96d2fe2f..1e106877 100755
> [...]