Re: [PATCH 1/4] dt-bindings: display: panel: Add Novatek NT37705

Hi Krzysztof,

On Mon May 4, 2026 at 10:45 PM CEST, Krzysztof Kozlowski wrote:
> On 04/05/2026 15:36, Luca Weiss wrote:
>> Hi Conor,
>> 
>> On Fri May 1, 2026 at 5:51 PM CEST, Conor Dooley wrote:
>>> On Fri, May 01, 2026 at 03:52:45PM +0200, Luca Weiss wrote:
>>>> Novatek NT37705 is a display driver IC used to drive AMOLED DSI panels.
>>>>
>>>> Describe it and the panel in the Fairphone (Gen. 6) (BJ631JHM-T71-D900
>>>> from BOE) using it.
>>>>
>>>> Signed-off-by: Luca Weiss <[email protected]>
>>>> ---
>>>>  .../bindings/display/panel/novatek,nt37705.yaml    | 72 ++++++++++++++++++++++
>>>>  1 file changed, 72 insertions(+)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/display/panel/novatek,nt37705.yaml b/Documentation/devicetree/bindings/display/panel/novatek,nt37705.yaml
>>>> new file mode 100644
>>>> index 000000000000..1c796599f6fc
>>>> --- /dev/null
>>>> +++ b/Documentation/devicetree/bindings/display/panel/novatek,nt37705.yaml
>>>> @@ -0,0 +1,72 @@
>>>> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
>>>> +%YAML 1.2
>>>> +---
>>>> +$id: http://devicetree.org/schemas/display/panel/novatek,nt37705.yaml#
>>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>>> +
>>>> +title: Novatek NT37705-based DSI display panels
>>>> +
>>>> +maintainers:
>>>> +  - Luca Weiss <[email protected]>
>>>> +
>>>> +description:
>>>> +  The Novatek NT37705 is a generic DSI Panel IC used to control AMOLED panels.
>>>> +
>>>> +allOf:
>>>> +  - $ref: panel-common.yaml#
>>>> +
>>>> +properties:
>>>> +  compatible:
>>>> +    contains:
>>>> +      const: boe,bj631jhm-t71-d900
>>>
>>> Compatible doesn't match the filename, nor does the commit message match
>>> what you've got here. Sounds like you're missing a fallback to
>>> $filename.
>> 
>> The last times I was upstreaming panel drivers (Feb 2024 and June 2025),
>> this was the requested way of doing things.
>
> So this was requested that time and is requested now. What is here
> uncertain?
>
>> 
>> Compatible being the company and model number making the actual panel
>> assembly (driver IC + touchscreen + glass etc), while the rest being
>> named after the driver IC manufacturer & number.
>
> So exactly what was asked for...

I don't quite understand what is asked for now, that's my issue.

1. Change the filename to boe,bj631jhm-t71-d900.yaml and leave the rest
   as-is.

2. Add a fallback compatible for novatek,nt37705. IIRC last time it was
   argued that a "generic" nt37705 driver will never be correct for a
   specific panel since it's missing a bunch of panel-specific init. So
   that's why there should not be a fallback to nt37705.

Either way, it's different to what I was working on with the two
examples I gave. Please help to clarify.

Regards
Luca

>> As seen in
>> * himax,hx83112b + djn,98-03057-6598b-i (Fairphone 3)
>> * himax,hx83112a + djn,9a-3r063-1102b (Fairphone 4)
>> 
>> Fairphone 5 panel (raydium,rm692e5) was upstreamed earlier and follows
>> different naming.