Re: [PATCH v7 5/8] clk: qcom: gcc-msm8939: mark Venus core GDSCs as hardware controlled
Bryan O'Donoghue <[email protected]>
| Newsgroups | org.kernel.vger.phone-devel,org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-clk,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel,org.kernel.vger.linux-media |
|---|---|
| Message-ID | <[email protected]> |
On 13/05/2026 22:24, Erikas Bitovtas wrote: > Since in downstream kernel VENUS_CORE0_GDSC and VENUS_CORE1_GDSC have a > device tree property "qcom,supports-hw-trigger", add a HW_CTRL_TRIGGER > flag to these GDSCs to indicate that their control can be passed to > hardware. > > Signed-off-by: Erikas Bitovtas<[email protected]> > --- I'm going to push back on this wording. Take ownership of the proposed solution. "Do what downstream does" is cargo-cultism. You have spotted a flag in downstream and tested your code with/without the change, clearly demonstrating that HW_CTRL_TRIGGER is required. Downstream is irrelevant. Your testing and imprimatur are all that is relevant to the commit log. Please fix. --- bod