Re: [PATCH v2 2/7] ASoC: codecs: aw88261: add TDM support
Mark Brown <[email protected]>
| Newsgroups | org.kernel.vger.phone-devel,org.kernel.vger.linux-kernel,org.kernel.vger.linux-sound |
|---|---|
| Message-ID | <[email protected]> |
On Mon, May 18, 2026 at 06:44:31PM -0300, Val Packett wrote:
> This amp supports TDM mode, so implement the set_tdm_slot operation to
> let the SoC driver configure the TDM slot number, width, and masks.
> +static int aw88261_set_tdm_slot(struct snd_soc_dai *dai,
> + unsigned int tx_mask, unsigned int rx_mask, int slots, int slot_width)
> +{
In spite of the changelog this doesn't actually seem to use slot_width?
It should.
Note also that we should disable TDM if slots == 0.
signature.asc
(application/pgp-signature, 488 B)
-----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmoMinYACgkQJNaLcl1U h9DFmQf8DuZC5d5sLd0pOXFn3jiruLWzBSp3peoHQCe34R4drrO0L8zMhgcOO35Z CbrZLXziFE/BUjlF0xwNbTCbGGIQmWVO7Z+HtfT5WZMCDXNc2cgtCkzlkB9d8zjy DC4Zmn7i8D2D+N0n+1z+JUnL6648z65bwgvxzQSHZO7YqqUBTC9YgMD8eOKf+RUg gpPjNlrGpjQ5u8KKWrCBWZ5CqVF/GKPzAMWrf13tS9D6gTsMFc4E54mCLDF9pXGz +IDv3mqKEFyWZxS7j9p4NhOPC1D4TdJHIE4eHVg+VP7d7EN20HfWB5cy0nJb6BD8 2QoR5jKc1CyUyXWLxOpAmsG4ZzgdOA== =7N0p -----END PGP SIGNATURE-----