Re: [PATCH v8 2/9] clk: qcom: gcc-msm8939: mark Venus core GDSCs as hardware controlled
Taniya Das <[email protected]>
| Newsgroups | org.kernel.vger.phone-devel,org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-clk,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel,org.kernel.vger.linux-media |
|---|---|
| Message-ID | <[email protected]> |
On 5/20/2026 2:02 PM, Bryan O'Donoghue wrote: > On 19/05/2026 16:10, Erikas Bitovtas wrote: >> Allow Venus core GDSCs to have their control passed to hardware, so they >> can be powered on by Venus firmware. >> >> Signed-off-by: Erikas Bitovtas <[email protected]> >> --- >> drivers/clk/qcom/gcc-msm8939.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/drivers/clk/qcom/gcc-msm8939.c b/drivers/clk/qcom/gcc- >> msm8939.c >> index 45193b3d714b..243d31a32e92 100644 >> --- a/drivers/clk/qcom/gcc-msm8939.c >> +++ b/drivers/clk/qcom/gcc-msm8939.c >> @@ -3664,6 +3664,7 @@ static struct clk_branch gcc_venus0_vcodec0_clk = { >> >> static struct clk_branch gcc_venus0_core0_vcodec0_clk = { >> .halt_reg = 0x4c02c, >> + .halt_check = BRANCH_HALT_SKIP, please use .halt_check = BRANCH_HALT >> .clkr = { >> .enable_reg = 0x4c02c, >> .enable_mask = BIT(0), >> @@ -3681,6 +3682,7 @@ static struct clk_branch >> gcc_venus0_core0_vcodec0_clk = { >> >> static struct clk_branch gcc_venus0_core1_vcodec0_clk = { >> .halt_reg = 0x4c034, >> + .halt_check = BRANCH_HALT_SKIP, please use .halt_check = BRANCH_HALT >> .clkr = { >> .enable_reg = 0x4c034, >> .enable_mask = BIT(0), >> @@ -3753,6 +3755,7 @@ static struct gdsc venus_core0_gdsc = { >> .pd = { >> .name = "venus_core0", >> }, >> + .flags = HW_CTRL_TRIGGER, >> .pwrsts = PWRSTS_OFF_ON, >> }; >> >> @@ -3761,6 +3764,7 @@ static struct gdsc venus_core1_gdsc = { >> .pd = { >> .name = "venus_core1", >> }, >> + .flags = HW_CTRL_TRIGGER, >> .pwrsts = PWRSTS_OFF_ON, >> }; >> >> >> -- >> 2.54.0 >> > > @Tanyia > > Can you confirm this change please ? > > --- > bod -- Thanks, Taniya Das