Re: [PATCH WIP v5 6/9] media: qcom: camss: csiphy-3ph: Update Gen2 v1.1 MIPI CSI-2 C-PHY init

On 01/06/2026 18:03, Bryan O'Donoghue wrote:
> On 31/05/2026 14:08, David Heidelberg via B4 Relay wrote:
>> From: David Heidelberg <[email protected]>
>>
>> These values should improve C-PHY behaviour. Should match most recent
>> Qualcomm code.
>>
>> Acked-by: Cory Keitz <[email protected]>
>> Suggested-by: Konrad Dybcio <[email protected]>
>> Signed-off-by: David Heidelberg <[email protected]>
>> ---
>>    .../media/platform/qcom/camss/camss-csiphy-3ph-1-0.c   | 18 +++++++++---------
>>    1 file changed, 9 insertions(+), 9 deletions(-)
>>
>> diff --git a/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c b/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c
>> index d837fcf7cd2f0..9a0f009c033bb 100644
>> --- a/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c
>> +++ b/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c
>> @@ -220,19 +220,19 @@ csiphy_lane_regs lane_regs_sdm845[] = {
>>    	{0x0660, 0x00, 0x00, CSIPHY_DEFAULT_PARAMS},
>>    	{0x0664, 0x7F, 0x00, CSIPHY_DEFAULT_PARAMS},
>>    };
>>
>>    /* GEN2 1.0 3PH */
>>    /* 3 entries: 3 lanes (C-PHY) */
>>    static const struct
>>    csiphy_lane_regs lane_regs_sdm845_3ph[] = {
>> -	{0x015c, 0x43, 0x00, CSIPHY_DEFAULT_PARAMS},
>> -	{0x0168, 0xa0, 0x00, CSIPHY_DEFAULT_PARAMS},
>> -	{0x016c, 0x25, 0x00, CSIPHY_DEFAULT_PARAMS},
>> +	{0x015c, 0x63, 0x00, CSIPHY_DEFAULT_PARAMS},
>> +	{0x0168, 0xac, 0x00, CSIPHY_DEFAULT_PARAMS},
>> +	{0x016c, 0xa5, 0x00, CSIPHY_DEFAULT_PARAMS},
>>    	{0x0104, 0x06, 0x00, CSIPHY_DEFAULT_PARAMS},
>>    	{0x010c, 0x12, 0x00, CSIPHY_SETTLE_CNT_LOWER_BYTE},
>>    	{0x0108, 0x00, 0x00, CSIPHY_SETTLE_CNT_HIGHER_BYTE},
>>    	{0x0114, 0x20, 0x00, CSIPHY_DEFAULT_PARAMS},
>>    	{0x0150, 0x00, 0x00, CSIPHY_DEFAULT_PARAMS},
>>    	{0x0118, 0x3e, 0x00, CSIPHY_DEFAULT_PARAMS},
>>    	{0x011c, 0x41, 0x00, CSIPHY_DEFAULT_PARAMS},
>>    	{0x0120, 0x41, 0x00, CSIPHY_DEFAULT_PARAMS},
>> @@ -240,19 +240,19 @@ csiphy_lane_regs lane_regs_sdm845_3ph[] = {
>>    	{0x0128, 0x00, 0x00, CSIPHY_DEFAULT_PARAMS},
>>    	{0x012c, 0x00, 0x00, CSIPHY_DEFAULT_PARAMS},
>>    	{0x0144, 0x12, 0x00, CSIPHY_DEFAULT_PARAMS},
>>    	{0x0160, 0x02, 0x00, CSIPHY_DEFAULT_PARAMS},
>>    	{0x01cc, 0x41, 0x00, CSIPHY_DEFAULT_PARAMS},
>>    	{0x0164, 0x00, 0x00, CSIPHY_DEFAULT_PARAMS},
>>    	{0x01dc, 0x51, 0x00, CSIPHY_DEFAULT_PARAMS},
>>
>> -	{0x035c, 0x43, 0x00, CSIPHY_DEFAULT_PARAMS},
>> -	{0x0368, 0xa0, 0x00, CSIPHY_DEFAULT_PARAMS},
>> -	{0x036c, 0x25, 0x00, CSIPHY_DEFAULT_PARAMS},
>> +	{0x035c, 0x63, 0x00, CSIPHY_DEFAULT_PARAMS},
>> +	{0x0368, 0xac, 0x00, CSIPHY_DEFAULT_PARAMS},
>> +	{0x036c, 0xa5, 0x00, CSIPHY_DEFAULT_PARAMS},
>>    	{0x0304, 0x06, 0x00, CSIPHY_DEFAULT_PARAMS},
>>    	{0x030c, 0x12, 0x00, CSIPHY_SETTLE_CNT_LOWER_BYTE},
>>    	{0x0308, 0x00, 0x00, CSIPHY_SETTLE_CNT_HIGHER_BYTE},
>>    	{0x0314, 0x20, 0x00, CSIPHY_DEFAULT_PARAMS},
>>    	{0x0350, 0x00, 0x00, CSIPHY_DEFAULT_PARAMS},
>>    	{0x0318, 0x3e, 0x00, CSIPHY_DEFAULT_PARAMS},
>>    	{0x031c, 0x41, 0x00, CSIPHY_DEFAULT_PARAMS},
>>    	{0x0320, 0x41, 0x00, CSIPHY_DEFAULT_PARAMS},
>> @@ -260,19 +260,19 @@ csiphy_lane_regs lane_regs_sdm845_3ph[] = {
>>    	{0x0328, 0x00, 0x00, CSIPHY_DEFAULT_PARAMS},
>>    	{0x032c, 0x00, 0x00, CSIPHY_DEFAULT_PARAMS},
>>    	{0x0344, 0x12, 0x00, CSIPHY_DEFAULT_PARAMS},
>>    	{0x0360, 0x02, 0x00, CSIPHY_DEFAULT_PARAMS},
>>    	{0x03cc, 0x41, 0x00, CSIPHY_DEFAULT_PARAMS},
>>    	{0x0364, 0x00, 0x00, CSIPHY_DEFAULT_PARAMS},
>>    	{0x03dc, 0x51, 0x00, CSIPHY_DEFAULT_PARAMS},
>>
>> -	{0x055c, 0x43, 0x00, CSIPHY_DEFAULT_PARAMS},
>> -	{0x0568, 0xa0, 0x00, CSIPHY_DEFAULT_PARAMS},
>> -	{0x056c, 0x25, 0x00, CSIPHY_DEFAULT_PARAMS},
>> +	{0x055c, 0x63, 0x00, CSIPHY_DEFAULT_PARAMS},
>> +	{0x0568, 0xac, 0x00, CSIPHY_DEFAULT_PARAMS},
>> +	{0x056c, 0xa5, 0x00, CSIPHY_DEFAULT_PARAMS},
>>    	{0x0504, 0x06, 0x00, CSIPHY_DEFAULT_PARAMS},
>>    	{0x050c, 0x12, 0x00, CSIPHY_SETTLE_CNT_LOWER_BYTE},
>>    	{0x0508, 0x00, 0x00, CSIPHY_SETTLE_CNT_HIGHER_BYTE},
>>    	{0x0514, 0x20, 0x00, CSIPHY_DEFAULT_PARAMS},
>>    	{0x0550, 0x00, 0x00, CSIPHY_DEFAULT_PARAMS},
>>    	{0x0518, 0x3e, 0x00, CSIPHY_DEFAULT_PARAMS},
>>    	{0x051c, 0x41, 0x00, CSIPHY_DEFAULT_PARAMS},
>>    	{0x0520, 0x41, 0x00, CSIPHY_DEFAULT_PARAMS},
>>
>> --
>> 2.53.0
>>
>>
>>
> 
> Squash this down !

Document the regs !

But now seriously - it's nice to have at least commit documenting what these 
change doing.

In previous discussion [1] we agreed on keeping this commit.

David

[1] 
https://lore.kernel.org/linux-media/[email protected]/

> 
> ---
> bod
> 

-- 
David Heidelberg